Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing code action functions for ide-rust #167

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Conversation

aminya
Copy link
Member

@aminya aminya commented Jun 14, 2021

Fixes #156

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needs tests

@aminya
Copy link
Member Author

aminya commented Jun 14, 2021

just needs tests

These are some custom functions with trivial defaults to extend the API. The main part that we care about is already tested in
https://github.com/atom-community/atom-languageclient/blob/code-actions-rust/test/adapters/code-action-adapter.test.ts

@aminya aminya merged commit 0f12e3b into master Jun 14, 2021
@aminya aminya deleted the code-actions-rust branch June 14, 2021 21:08
@UziTech
Copy link
Member

UziTech commented Jun 14, 2021

One test that checks that those functions are called and returning false prevents applying should be good.

@github-actions
Copy link

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge alexheretic/atom-languageclient/tree/build to support ide-rust
2 participants